1. This site uses cookies. By continuing to use this site, you are agreeing to our use of cookies. Learn More.

Fixed Licenses cannot be downloaded for non expiring products!

Discussion in 'Resolved Bugs' started by Liam W, Sep 19, 2014.

  1. Liam W

    Liam W Member

    Again, the expiry date is compared with the upload date with a less than. For non expiring licences, the check always fails and the license cannot be downloaded.

    Liam
     
  2. Chris D

    Chris D Xen Resources Developer Staff Member Xen Notices

    Did you upgrade to 1.1.2 before reporting this bug because this was fixed in 1.1.2.
     
  3. Liam W

    Liam W Member

    I don't know.

    I don't what which version I downloaded to check either. Let me look.
     
  4. Chris D

    Chris D Xen Resources Developer Staff Member Xen Notices

    Pretty important part of troubleshooting and reporting bugs, Liam.

    1) Which version am I running?
    2) Are there any upgrades available?
     
    RobUK likes this.
  5. Liam W

    Liam W Member

    I am running 1.1.2, and it should be working... I'll ask them to try again.

    Strange,
    Liam
     
  6. Chris D

    Chris D Xen Resources Developer Staff Member Xen Notices

    You downloaded version 1.1.2 today only 8 minutes before reporting this bug so perhaps you had received reports of the issue prior to installing 1.1.2.
     
  7. Liam W

    Liam W Member

    Pretty sure I downloaded it before as well.

    Liam
     
  8. Chris D

    Chris D Xen Resources Developer Staff Member Xen Notices

    Just tested it and cannot reproduce at the moment.
     
  9. Liam W

    Liam W Member

    The person says they're still having the issue.

    I'll do some more digging.

    Liam
     
  10. Liam W

    Liam W Member

    @Chris D

    I figured out the bug. You're checking to see if the product has a license length, however for this particular product I changed it from non-expiring to expiring after 12 months, so as that check passes, the other check fails.

    Liam
     
  11. Chris D

    Chris D Xen Resources Developer Staff Member Xen Notices

    OK.

    Can you verify for me if changing Line 104 in XenProduct/ControllerHelper/Product.php to the following solves the problem?
    PHP:
    if ($license['expiry_date'] && $license['expiry_date'] < $version['release_date'])
     
  12. Liam W

    Liam W Member

    I already changed it before replying, I'll wait for someone to report to me if it's working now or not.

    Thanks :)

    Liam
     
    Chris D likes this.
  13. Liam W

    Liam W Member

    That's definitely fixed it :)

    Liam
     
    Chris D likes this.

Share This Page